From: Simon Horman Subject: [patch] Fix xm pci-detach for inactive devices Date: Tue, 26 May 2009 14:38:24 +1000 Message-ID: <20090526043821.GA24218@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Masaki Kanno , Zhai Edwin List-Id: xen-devel@lists.xenproject.org In the case where a device is attached to an inactive domain and then removed before the domain is activated it won't have a vslot assigned, but it should still be valid to remove it. I don't think that there are any other cases where vslot can be invalid. Lightly tested Cc: Zhai Edwin Cc: Masaki Kanno Signed-off-by: Simon Horman Index: xen-unstable.hg/tools/python/xen/xend/XendDomainInfo.py =================================================================== --- xen-unstable.hg.orig/tools/python/xen/xend/XendDomainInfo.py 2009-05-26 14:37:15.000000000 +1000 +++ xen-unstable.hg/tools/python/xen/xend/XendDomainInfo.py 2009-05-26 14:37:18.000000000 +1000 @@ -1130,9 +1130,6 @@ class XendDomainInfo: if devnum >= pci_len: raise VmError("Device @ vslot 0x%x doesn't exist." % (vslot)) - if vslot == AUTO_PHP_SLOT: - raise VmError("Device @ vslot 0x%x doesn't support hotplug." % (vslot)) - # Check the co-assignment. # To pci-detach a device D from domN, we should ensure: for each DD in the # list of D's co-assignment devices, DD is not assigned (to domN).