From: Baruch Siach Subject: Re: [PATCH] netdev: enc28j60: use IRQF_TRIGGER_FALLING for IRQ by default Date: Tue, 26 May 2009 14:06:15 +0300 Message-ID: <20090526110614.GA1987@jasper.tkos.co.il> References: <1243333007-25645-1-git-send-email-vapier@gentoo.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Michael Hennerich , Bryan Wu , David Brownell To: Mike Frysinger Return-path: Received: from tango.tkos.co.il ([62.219.50.35]:42389 "EHLO tango.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbZEZMHM (ORCPT ); Tue, 26 May 2009 08:07:12 -0400 Content-Disposition: inline In-Reply-To: <1243333007-25645-1-git-send-email-vapier@gentoo.org> Sender: netdev-owner@vger.kernel.org List-ID: Hi Michael, On Tue, May 26, 2009 at 06:16:47AM -0400, Mike Frysinger wrote: > From: Michael Hennerich > > Rather than have the default IRQ flags not be usable, use the logical > settings which match the hardware. Since the part is /INT, it makes sense > to have it default to a falling trigger. If a board truly needs something > different, it still can tweak the defaults in its own board file. You revert David Brownell's commit here (c7b7b042068cd12b8b155722d24686f70b88ced1). Added to CC. > > Signed-off-by: Michael Hennerich > Signed-off-by: Mike Frysinger > Signed-off-by: Bryan Wu > CC: Baruch Siach > --- > drivers/net/enc28j60.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/enc28j60.c b/drivers/net/enc28j60.c > index 36cb6e9..fbe2012 100644 > --- a/drivers/net/enc28j60.c > +++ b/drivers/net/enc28j60.c > @@ -1562,7 +1562,7 @@ static int __devinit enc28j60_probe(struct spi_device *spi) > /* Board setup must set the relevant edge trigger type; > * level triggers won't currently work. > */ > - ret = request_irq(spi->irq, enc28j60_irq, 0, DRV_NAME, priv); > + ret = request_irq(spi->irq, enc28j60_irq, IRQF_TRIGGER_FALLING, DRV_NAME, priv); > if (ret < 0) { > if (netif_msg_probe(priv)) > dev_err(&spi->dev, DRV_NAME ": request irq %d failed " baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -