From: Jean-Christophe PLAGNIOL-VILLARD Date: Tue, 26 May 2009 23:44:04 +0200 Subject: [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion In-Reply-To: <20090526213052.GC4669@b07421-ec1.am.freescale.net> References: <200905260940.50045.sr@denx.de> <73173D32E9439E4ABB5151606C3E19E201CF9E6BDC@SC-VEXCH1.marvell.com> <20090526213052.GC4669@b07421-ec1.am.freescale.net> Message-ID: <20090526214404.GA30039@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 16:30 Tue 26 May , Scott Wood wrote: > On Tue, May 26, 2009 at 01:48:08AM -0700, Prafulla Wadaskar wrote: > > Good Feedback... > > The name board_nand_init() is confusing here.... Why the board specific code is in drivers/mtd/nand/? > > Whereas I can see more references in board/* > > But looking other code references in this folder your feedback stands valid > > BTW: the arch_nand_init() or device_nand_init() is the right name > > here...Scott need to suggest on this since it involves rework on other > > drivers too. > > Rather than just change the name, we should do something more similar to > Linux, where the driver is called with an initfunc (or explicitly by > board/arch code), which in turn calls nand_scan[1], and places itself at > the appropriate spot in nand_chip[]. > > nand_init and nand_init_chip would go away. the initcall patch I send few days ago will clearly help on this too Best Regards, J.