From: Simon Horman Subject: [patch 7/9] xm: xen-api, pass-through: create: Use vslot for hotplug_slot Date: Thu, 04 Jun 2009 13:21:22 +1000 Message-ID: <20090604032230.760859830@vergenet.net> References: <20090604032115.934982694@vergenet.net> Return-path: Content-Disposition: inline; filename=xenapi_create-vslot.patch List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Masaki Kanno , Dexuan Cui List-Id: xen-devel@lists.xenproject.org Using func for hotplug_slot is not correct, although func is often zero, previously zero meant please pick a vslot and asking xend to pick a vslot was the only method available. This resolves the following error when using Xen API: $ xm create hvm.conf ... Internal error: Timed out waiting for device model action. Cc: Dexuan Cui Cc: Masaki Kanno Signed-off-by: Simon Horman Index: xen-unstable.hg/tools/python/xen/xm/xenapi_create.py =================================================================== --- xen-unstable.hg.orig/tools/python/xen/xm/xenapi_create.py 2009-06-04 08:30:35.000000000 +1000 +++ xen-unstable.hg/tools/python/xen/xm/xenapi_create.py 2009-06-04 08:31:01.000000000 +1000 @@ -539,7 +539,7 @@ class xenapi_create: "PPCI": target_ref, "hotplug_slot": - int(pci.attributes["func"].value, 16), + int(pci.attributes["vslot"].value, 16), "options": get_child_nodes_as_dict(pci, "pci_opt", "key", "value") --