From: Rusty Russell Subject: Re: [PATCH 2/2] Add serial number support for virtio_blk, V4a Date: Thu, 4 Jun 2009 16:01:16 +0930 Message-ID: <200906041601.16539.rusty@rustcorp.com.au> References: <4A1F6130.9070705@redhat.com> <4A26E607.3070901@redhat.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="Boundary-00=_0o2JKyrOHPfF/PI" Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, KVM list , Christoph Hellwig To: john cooper Return-path: In-Reply-To: <4A26E607.3070901@redhat.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org --Boundary-00=_0o2JKyrOHPfF/PI Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit On Thu, 4 Jun 2009 06:37:19 am john cooper wrote: > This patch extracts the opaque data from pci i/o > region 0 via the added VIRTIO_BLK_F_IDENTIFY > field. By convention this data takes the form of > that returned by an ATA IDENTIFY DEVICE command, > however the driver (except for structure size) > makes no interpretation of the data. The structure > data is copied wholesale to userspace via a > HDIO_GET_IDENTITY ioctl command (eg: hdparm -i ). Thanks, applied with one subtraction: > +/* mapped into pci i/o region 0 > + */ > struct virtio_blk_config I removed this comment; it's true for virtio_pci, but not true in general. Thanks! Rusty. --Boundary-00=_0o2JKyrOHPfF/PI Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: 7bit On Thu, 4 Jun 2009 06:37:19 am john cooper wrote:
> This patch extracts the opaque data from pci i/o
> region 0 via the added VIRTIO_BLK_F_IDENTIFY
> field. By convention this data takes the form of
> that returned by an ATA IDENTIFY DEVICE command,
> however the driver (except for structure size)
> makes no interpretation of the data. The structure
> data is copied wholesale to userspace via a
> HDIO_GET_IDENTITY ioctl command (eg: hdparm -i <dev>).


Thanks, applied with one subtraction:


> +/* mapped into pci i/o region 0
> + */
> struct virtio_blk_config


I removed this comment; it's true for virtio_pci, but not true in general.


Thanks!
Rusty.

--Boundary-00=_0o2JKyrOHPfF/PI--