From: Vasanthakumar Thiagarajan Date: Fri, 5 Jun 2009 12:00:59 +0530 Subject: [ath9k-devel] [PATCH 01/15] ath9k: fix oops by downgrading assert in rc.c In-Reply-To: <1244180502-4323-2-git-send-email-lrodriguez@atheros.com> References: <1244180502-4323-1-git-send-email-lrodriguez@atheros.com> <1244180502-4323-2-git-send-email-lrodriguez@atheros.com> Message-ID: <20090605063059.GF17632@vasanth-laptop> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org > + > + /* > + * Fine tuning for when no decent rate was found, the > + * lowest should *not* be used under normal circumstances. > + */ > + if (rix == ath_rc_priv->valid_rate_index[0]) { > + DPRINTF(sc, ATH_DBG_RATE, "lowest rate being used, " > + "disabling MRR\n"); > + rates[0].idx = rate_lowest_index(sband, sta); > + /* Disable MRR when ath_rc_ratefind_ht() found rate 0 */ > + rates[1].idx = -1; > + } I think we can still fill other rates (1..3) with the lowest rate index as we dont differentiate the situation where the lowest rate is chosen truely by the algorithm from this particular case. Vasanth