From: Mark Brown Subject: Re: [PATCH] ASoC: Automatically set TDM if needed on pxa-ssp and allow frame width override when using TDM. Date: Wed, 10 Jun 2009 15:47:14 +0100 Message-ID: <20090610144714.GA7767@rakim.wolfsonmicro.main> References: <1244567590.7406.100.camel@brutus> <20090610121844.GC14632@sirena.org.uk> <1244644794.27053.210.camel@brutus> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id E35CB2441B for ; Wed, 10 Jun 2009 16:47:15 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1244644794.27053.210.camel@brutus> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Daniel Ribeiro Cc: Paul Shen , alsa-devel , Eric Miao , linux-arm-kernel , Philipp Zabel List-Id: alsa-devel@alsa-project.org On Wed, Jun 10, 2009 at 11:39:54AM -0300, Daniel Ribeiro wrote: > Em Qua, 2009-06-10 =E0s 13:18 +0100, Mark Brown escreveu: > > This is wrong, the WM9081 is a DAC only part so it should be paying > > attention to the RX mask, not the TX one. We also need to handle the > > sample size here. > Ok, but I dont know how to handle slot_width for wm9081. Is a FIXME > comment here enough for a first version? Its hard for me to get this > working correctly on wm9081 as I dont have such hardware and PCAP2 only > supports 16bits slots. The sample size code from the hw_params() function should be copied in here and the sample size remembered in the wm9081_priv structure. Then in hw_params() the sample size would get ignored if one had been configured via set_tdm_slot(). A size of zero should be supported there to allow dropping of TDM mode.