From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 05/11] qemu: MSI-X support functions Date: Wed, 10 Jun 2009 15:39:05 +0100 Message-ID: <200906101539.12367.paul@codesourcery.com> References: <200906101507.39823.paul@codesourcery.com> <20090610142508.GA28409@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, Avi Kivity , Carsten Otte , kvm@vger.kernel.org, Rusty Russell , virtualization@lists.linux-foundation.org, Christian Borntraeger , Blue Swirl To: "Michael S. Tsirkin" Return-path: Received: from mail.codesourcery.com ([65.74.133.4]:33490 "EHLO mail.codesourcery.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753675AbZFJOjM (ORCPT ); Wed, 10 Jun 2009 10:39:12 -0400 In-Reply-To: <20090610142508.GA28409@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: > > If we really need to avoid MSI-X capable devices then that should be done > > explicity per-device. i.e. you have a different virtio-net device that > > does not use MSI-X. > > > > Paul > > Why should it be done per-device? Because otherwise you end up with the horrible hacks that you're currently tripping over: devices have to magically morph into a different device when you load a VM. That's seems just plain wrong to me. Loading a VM shouldn't not do anything that can't happen during normal operation. Paul