Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757913AbZFLLAq (ORCPT ); Fri, 12 Jun 2009 07:00:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751324AbZFLLAi (ORCPT ); Fri, 12 Jun 2009 07:00:38 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:35443 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099AbZFLLAi (ORCPT ); Fri, 12 Jun 2009 07:00:38 -0400 Date: Fri, 12 Jun 2009 13:00:39 +0200 From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: apw@shadowen.org, w.sang@pengutronix.de Subject: checkpatch: false positives for __.*const Message-ID: <20090612110039.GA5650@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BXVAT5kNtrzKuDFl" Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: wsa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --BXVAT5kNtrzKuDFl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, init.h defines some attributes starting with '__' and ending with const, li= ke '__devinitconst'. They produce false positives with checkpatch: ERROR: "fooconst bar" should be "foo const bar" #154: FILE: drivers/uio/uio_of_genirq.c:70: +static const struct of_device_id __devinitconst uio_of_genirq_match[] =3D { like caused by this patch: http://patchwork.kernel.org/patch/29664/ I investigated a bit but I am not sure if this should be fixed in the regexp responsible for this error or, more general, in $Attributes. Regards Wolfram --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --BXVAT5kNtrzKuDFl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkoyNVcACgkQD27XaX1/VRt+fQCffVqoKYsZeleHlP+qSFo9KOaG GN0AnRpCNfLwESM7cUvV35/VNvk3J2SS =n0z/ -----END PGP SIGNATURE----- --BXVAT5kNtrzKuDFl--