From: Jean-Christophe PLAGNIOL-VILLARD Date: Wed, 24 Jun 2009 01:47:06 +0200 Subject: [U-Boot] [PATCH 2/3] A320: driver for FTRTC010 real time clock In-Reply-To: References: Message-ID: <20090623234706.GA6875@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > + > +static volatile struct ftrtc010 *rtc = (struct ftrtc010 *)CONFIG_SYS_RTC_BASE; > + > +static void ftrtc_enable (void) you use it at one please only the reset > +{ > + rtc->cr = cpu_to_le32 (FTRTC010_CR_ENABLE); so please move this code there > +} > + > +/* > + * return current time in seconds > + */ > +static unsigned long ftrtc_time (void) > +{ > + unsigned long day; > + unsigned long hour; > + unsigned long minute; > + unsigned long second; > + unsigned long second2; > + > + do { > + second = le32_to_cpu (rtc->sec); please use proper accessor readl/writel Best Regards, J.