Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MLzQ6-0006fU-Hg for mharc-grub-devel@gnu.org; Wed, 01 Jul 2009 09:00:14 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLzQ4-0006dh-4i for grub-devel@gnu.org; Wed, 01 Jul 2009 09:00:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLzPx-0006bT-EW for grub-devel@gnu.org; Wed, 01 Jul 2009 09:00:11 -0400 Received: from [199.232.76.173] (port=45653 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLzPx-0006bO-6V for grub-devel@gnu.org; Wed, 01 Jul 2009 09:00:05 -0400 Received: from aybabtu.com ([69.60.117.155]:49286) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MLzPw-00057Q-NM for grub-devel@gnu.org; Wed, 01 Jul 2009 09:00:04 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MLyM7-0007M7-TI for grub-devel@gnu.org; Wed, 01 Jul 2009 13:52:04 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MLzPu-0004ds-6G for grub-devel@gnu.org; Wed, 01 Jul 2009 15:00:02 +0200 Date: Wed, 1 Jul 2009 15:00:02 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090701130002.GB17770@thorin> References: <20090629130840.GA11687@thorin> <20090629210512.clgmx15fggsc40sw-cebfxv@webmail.spamcop.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090629210512.clgmx15fggsc40sw-cebfxv@webmail.spamcop.net> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH] use $(target_cpu) in conf/*.rmk X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2009 13:00:12 -0000 On Mon, Jun 29, 2009 at 09:05:12PM -0400, Pavel Roskin wrote: > Quoting Robert Millan : > >> >> This patch replaces a few hardcoded architecture names in conf/*.rmk >> with $(target_cpu). It makes it easier to share code. >> >> As a result of this, the setjmp module declarations are unified. >> >> grub-emu can too be unified similarly, although >> util/$(target_cpu)/$(platform)/misc.c >> might be better off with a complete merge (they're always identical, >> or almost). > > Fine with me. Committed. > I'm actually thinking of making dl.c similar to each other by using the > notation without "32" and "64". At least it would be easier to compare > them. Yeah, I was thinking that too. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."