Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOEYv-0001sd-8C for qemu-devel@nongnu.org; Tue, 07 Jul 2009 13:34:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOEYs-0001rK-Nv for qemu-devel@nongnu.org; Tue, 07 Jul 2009 13:34:36 -0400 Received: from [199.232.76.173] (port=45928 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOEYs-0001rF-IC for qemu-devel@nongnu.org; Tue, 07 Jul 2009 13:34:34 -0400 Received: from verein.lst.de ([213.95.11.210]:57406) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MOEYs-0003M5-2Q for qemu-devel@nongnu.org; Tue, 07 Jul 2009 13:34:34 -0400 Date: Tue, 7 Jul 2009 19:34:32 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] qemu-io: Implement bdrv_get_buffer/bdrv_put_buffer Message-ID: <20090707173432.GB5145@lst.de> References: <1246964267-6923-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1246964267-6923-1-git-send-email-kwolf@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, hch@lst.de On Tue, Jul 07, 2009 at 12:57:47PM +0200, Kevin Wolf wrote: > The get_buffer and put_buffer functions are implemented as a variation of the > normal read/write operation, enabled by the -b option. This is the same > mechanism as is used to switch from read/write to pread/pwrite. Looks good to me.