From: Jean-Christophe PLAGNIOL-VILLARD Date: Tue, 7 Jul 2009 22:24:32 +0200 Subject: [U-Boot] [PATCH v4 3/6] ARM: Add macros.h to be used in assembler file. In-Reply-To: <20090707193316.EF032832E416@gemini.denx.de> References: <4a62b27ae616d894b9302d1b73a3e4a71bbdfbf1.1244918138.git.lilja.magnus@gmail.com> <6fd22327241accc2efcada8380923c8e9c523790.1244918138.git.lilja.magnus@gmail.com> <20090707193316.EF032832E416@gemini.denx.de> Message-ID: <20090707202432.GK30172@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 21:33 Tue 07 Jul , Wolfgang Denk wrote: > Dear Magnus Lilja, > > In message <6fd22327241accc2efcada8380923c8e9c523790.1244918138.git.lilja.magnus@gmail.com> you wrote: > > Changes from last version: Added documentation for the macros. > > > > include/asm-arm/macro.h | 74 +++++++++++++++++++++++++++++++++++++++++++++++ > > 1 files changed, 74 insertions(+), 0 deletions(-) > > create mode 100644 include/asm-arm/macro.h > > Sorry for the late comment... > > ... > > +/* > > + * These macros provide a convenient way to write 8, 16 and 32 bit data > > + * to any address. > > I think this comment might be wrong. It should probably read "... to > any _memory_ address". Using these macros to access device registers > and the like is probably nore recommended? you can access cpu register without problem with these macros Best Regards, J.