From: Christoph Hellwig Subject: Re: [PATCH] virtio_blk: ioctl return value fix Date: Wed, 8 Jul 2009 20:12:20 +0200 Message-ID: <20090708181220.GB10552@lst.de> References: <20090620192941.GA26873@lst.de> <200906231643.10623.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Rusty Russell Return-path: Content-Disposition: inline In-Reply-To: <200906231643.10623.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, Jun 23, 2009 at 04:43:10PM +0930, Rusty Russell wrote: > On Sun, 21 Jun 2009 04:59:41 am Christoph Hellwig wrote: > > Block driver ioctl methods must return ENOTTY and not -ENOIOCTLCMD if > > they expect the block layer to handle generic ioctls. > > > > This triggered a BLKROSET failure in xfsqa #200. > > Applied. Can you send on this fix to Linus? It fixes a regression introduced in Linux 2.6.30.