From: Rusty Russell Subject: Re: [PATCH] virtio_blk: ioctl return value fix Date: Thu, 9 Jul 2009 22:18:38 +0930 Message-ID: <200907092218.39209.rusty@rustcorp.com.au> References: <20090620192941.GA26873@lst.de> <200906231643.10623.rusty@rustcorp.com.au> <20090708181220.GB10552@lst.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Christoph Hellwig Return-path: Received: from ozlabs.org ([203.10.76.45]:59302 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759854AbZGIMsq (ORCPT ); Thu, 9 Jul 2009 08:48:46 -0400 In-Reply-To: <20090708181220.GB10552@lst.de> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 9 Jul 2009 03:42:20 am Christoph Hellwig wrote: > On Tue, Jun 23, 2009 at 04:43:10PM +0930, Rusty Russell wrote: > > On Sun, 21 Jun 2009 04:59:41 am Christoph Hellwig wrote: > > > Block driver ioctl methods must return ENOTTY and not -ENOIOCTLCMD if > > > they expect the block layer to handle generic ioctls. > > > > > > This triggered a BLKROSET failure in xfsqa #200. > > > > Applied. > > Can you send on this fix to Linus? It fixes a regression introduced in > Linux 2.6.30. Yep, I've been away, but they'll both be pushed soon with other (minor) lguest/virtio fixes. I'm holding on a final lguest regression which I need to track down. Thanks, Rusty.