From: Jean-Christophe PLAGNIOL-VILLARD Date: Sun, 12 Jul 2009 18:07:27 +0200 Subject: [U-Boot] [PATCH v6 2/2] Marvell Sheevaplug Board support In-Reply-To: <20090712155407.70461832E416@gemini.denx.de> References: <1247241040-21944-1-git-send-email-prafulla@marvell.com> <1247241040-21944-2-git-send-email-prafulla@marvell.com> <20090712125148.GC21713@game.jcrosoft.org> <20090712143704.20570832E416@gemini.denx.de> <20090712151534.GF7218@game.jcrosoft.org> <20090712155407.70461832E416@gemini.denx.de> Message-ID: <20090712160727.GC21651@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 17:54 Sun 12 Jul , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20090712151534.GF7218@game.jcrosoft.org> you wrote: > > > > > > > +#undef CONFIG_CMD_FLASH > > > > > +#define CONFIG_SYS_NO_FLASH /* Declare no flash (NOR/SPI) */ > > > > please move this 2 > > > > > + > > > > > +#include > > > > > +#define CONFIG_CMD_AUTOSCRIPT > > > > > +#define CONFIG_CMD_DHCP > > > > > +#define CONFIG_CMD_ENV > > > > > +#define CONFIG_CMD_FAT > > > > > +#define CONFIG_CMD_NAND > > > > > +#define CONFIG_CMD_PING > > > > > +#define CONFIG_CMD_USB > > > > here > > > > > > Why? > > how this suppose to work? > > you undef the CMD_FLASH et redefine it from the default? > > Good. It would be nice if you added such an explanation to your > comment, so people understand why you are making such requests. > Otherwise they might assume you just had to make any comment. ok it was too obvious for me Best Regards, J.