Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MRT7L-0001bn-1I for mharc-grub-devel@gnu.org; Thu, 16 Jul 2009 11:43:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRT7J-0001a7-Kp for grub-devel@gnu.org; Thu, 16 Jul 2009 11:43:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRT7F-0001UP-4c for grub-devel@gnu.org; Thu, 16 Jul 2009 11:43:29 -0400 Received: from [199.232.76.173] (port=49091 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRT7F-0001UJ-21 for grub-devel@gnu.org; Thu, 16 Jul 2009 11:43:25 -0400 Received: from aybabtu.com ([69.60.117.155]:53033) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MRT7E-0007LB-HX for grub-devel@gnu.org; Thu, 16 Jul 2009 11:43:24 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MRS1x-0003YG-VU for grub-devel@gnu.org; Thu, 16 Jul 2009 16:33:57 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MRT72-0001po-Ry for grub-devel@gnu.org; Thu, 16 Jul 2009 17:43:12 +0200 Date: Thu, 16 Jul 2009 17:43:12 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090716154312.GB6771@thorin> References: <20090715010017.17865.58915.stgit@mj.roinet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090715010017.17865.58915.stgit@mj.roinet.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: Re: [PATCH 1/7] Make boot/i386/pc/boot.S safer to modify X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2009 15:43:29 -0000 On Tue, Jul 14, 2009 at 09:00:17PM -0400, Pavel Roskin wrote: > ChangeLog: > > * include/grub/i386/pc/boot.h: Sort all offsets. > (GRUB_BOOT_MACHINE_KERNEL_ADDRESS): Remove, it's unused. > (GRUB_BOOT_MACHINE_KERNEL_SEGMENT): Likewise. > * boot/i386/pc/boot.S: Assert location of every offset listed in > include/grub/i386/pc/boot.h. > --- > boot/i386/pc/boot.S | 8 +++++++- > include/grub/i386/pc/boot.h | 10 ++-------- > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/boot/i386/pc/boot.S b/boot/i386/pc/boot.S > index 8d8c27c..fb90947 100644 > --- a/boot/i386/pc/boot.S > +++ b/boot/i386/pc/boot.S > @@ -65,6 +65,7 @@ start: > * this area. > */ > > + . = _start + GRUB_BOOT_MACHINE_BPB_START > . = _start + 4 Why is this +4 still needed? If it's alignment, I'd make it explicit. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."