Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MSfgW-000312-90 for qemu-devel@nongnu.org; Sun, 19 Jul 2009 19:20:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MSfgR-0002zA-Iv for qemu-devel@nongnu.org; Sun, 19 Jul 2009 19:20:47 -0400 Received: from [199.232.76.173] (port=36914 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MSfgR-0002z7-ES for qemu-devel@nongnu.org; Sun, 19 Jul 2009 19:20:43 -0400 Received: from verein.lst.de ([213.95.11.210]:46001) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MSfgR-0001N3-0N for qemu-devel@nongnu.org; Sun, 19 Jul 2009 19:20:43 -0400 Received: from verein.lst.de (localhost [127.0.0.1]) by verein.lst.de (8.12.3/8.12.3/Debian-7.1) with ESMTP id n6JNKfgh002001 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO) for ; Mon, 20 Jul 2009 01:20:41 +0200 Received: (from hch@localhost) by verein.lst.de (8.12.3/8.12.3/Debian-7.2) id n6JNKfu3001999 for qemu-devel@nongnu.org; Mon, 20 Jul 2009 01:20:41 +0200 Date: Mon, 20 Jul 2009 01:20:41 +0200 From: Christoph Hellwig Message-ID: <20090719232041.GB1923@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] qemu-iotests: test invalid pattern argument handling in qemu-io List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Signed-off-by: Christoph Hellwig Index: qemu-iotests/021 =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ qemu-iotests/021 2009-07-20 01:14:59.036900470 +0200 @@ -0,0 +1,62 @@ +#!/bin/sh +# +# Test handling of invalid patterns arguments to qemu-io +# +# Copyright (C) 2009 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# + +# creator +owner=hch@lst.de + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! + +_cleanup() +{ + _cleanup_test_img +} +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter + +_supported_fmt generic +_supported_os Linux + + +size=128M +_make_test_img $size + +INVALID_PATTERNS="-1 300 12m 4k route66" +TEST_OPS="writev read write readv aio_read aio_write" + +for pattern in $INVALID_PATTERNS; do + for op in $TEST_OPS; do + echo + echo "== testing $op -P $pattern ==" + $QEMU_IO -c "$op -P $pattern 0 4096" $TEST_IMG | _filter_qemu_io + done +done + +# success, all done +echo "*** done" +rm -f $seq.full +status=0 Index: qemu-iotests/021.out =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ qemu-iotests/021.out 2009-07-20 01:15:13.665927870 +0200 @@ -0,0 +1,93 @@ +QA output created by 021 +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 + +== testing writev -P -1 == +-1 is not a valid pattern byte + +== testing read -P -1 == +-1 is not a valid pattern byte + +== testing write -P -1 == +-1 is not a valid pattern byte + +== testing readv -P -1 == +-1 is not a valid pattern byte + +== testing aio_read -P -1 == +-1 is not a valid pattern byte + +== testing aio_write -P -1 == +-1 is not a valid pattern byte + +== testing writev -P 300 == +300 is not a valid pattern byte + +== testing read -P 300 == +300 is not a valid pattern byte + +== testing write -P 300 == +300 is not a valid pattern byte + +== testing readv -P 300 == +300 is not a valid pattern byte + +== testing aio_read -P 300 == +300 is not a valid pattern byte + +== testing aio_write -P 300 == +300 is not a valid pattern byte + +== testing writev -P 12m == +12m is not a valid pattern byte + +== testing read -P 12m == +12m is not a valid pattern byte + +== testing write -P 12m == +12m is not a valid pattern byte + +== testing readv -P 12m == +12m is not a valid pattern byte + +== testing aio_read -P 12m == +12m is not a valid pattern byte + +== testing aio_write -P 12m == +12m is not a valid pattern byte + +== testing writev -P 4k == +4k is not a valid pattern byte + +== testing read -P 4k == +4k is not a valid pattern byte + +== testing write -P 4k == +4k is not a valid pattern byte + +== testing readv -P 4k == +4k is not a valid pattern byte + +== testing aio_read -P 4k == +4k is not a valid pattern byte + +== testing aio_write -P 4k == +4k is not a valid pattern byte + +== testing writev -P route66 == +route66 is not a valid pattern byte + +== testing read -P route66 == +route66 is not a valid pattern byte + +== testing write -P route66 == +route66 is not a valid pattern byte + +== testing readv -P route66 == +route66 is not a valid pattern byte + +== testing aio_read -P route66 == +route66 is not a valid pattern byte + +== testing aio_write -P route66 == +route66 is not a valid pattern byte +*** done Index: qemu-iotests/group =================================================================== --- qemu-iotests.orig/group 2009-07-20 01:11:10.838923390 +0200 +++ qemu-iotests/group 2009-07-20 01:11:25.206168581 +0200 @@ -27,3 +27,4 @@ 018 rw backing auto 019 rw backing auto 020 rw backing auto +021 io auto