From: Greg KH Subject: Re: [patch 00/54] [Announce] Microsoft Hyper-V drivers for Linux Date: Mon, 20 Jul 2009 10:36:33 -0700 Message-ID: <20090720173633.GB25406@suse.de> References: <20090720160025.GA20249@kroah.com> <20090720162810.GA22102@kroah.com> <20090720165941.GA15660@redhat.com> <20090720170911.GS12833@kiste.smurf.noris.de> <20090720171523.GA16129@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20090720171523.GA16129@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Dave Jones , Matthias Urlichs , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, virtualization@lists.osdl.org, Hank Janssen List-Id: virtualization@lists.linuxfoundation.org On Mon, Jul 20, 2009 at 01:15:23PM -0400, Dave Jones wrote: > On Mon, Jul 20, 2009 at 07:09:11PM +0200, Matthias Urlichs wrote: > > Hi, > > > > Dave Jones: > > > Given the numerous cleanup patches that already exist, is there any reason > > > to not just post the cleaned up drivers ? It would certainly be more > > > reviewable than the current pile. > > > > > Feel free to apply / combinediff these patches before reviewing. :-P > > > > Personally, I don't want to ever see another patch where substantial > > changes (for some nontrivial value of "substantial") are intermixed > > with distracting s/\/bool/g cleanups. > > 'Substantial changes' doesn't matter when it's an initial submission. > By its nature, it's a substantial change. Note, to keep the proper authorship information, for a lot of drivers in the staging tree, we commit the original driver with the correct Author: and signed-off-by lines, and then we do cleanups after that to properly attribute the developers doing that work. thanks, greg k-h