From: Matthias Fuchs Date: Wed, 22 Jul 2009 12:14:25 +0200 Subject: [U-Boot] [PATCH V5] ppc4xx: Add 405EP based PMC405DE board In-Reply-To: <20090722094145.A7745832E416@gemini.denx.de> References: <12481717431327-git-send-email-matthias.fuchs@esd.eu> <200907220936.55822.sr@denx.de> <20090722094145.A7745832E416@gemini.denx.de> Message-ID: <200907221214.25935.matthias.fuchs@esd.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang, On Wednesday 22 July 2009 11:41, Wolfgang Denk wrote: > Dear Stefan Roese, > > In message <200907220936.55822.sr@denx.de> you wrote: > > Hi Wolfgang, > > > > On Wednesday 22 July 2009 09:26:09 Wolfgang Denk wrote: > > > > +struct ppc4xx_config ppc4xx_config_val[] = { > > > > + > > > > + { "133", "CPU: 133 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66", > > > > + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > > > + 0x00, 0x40, 0x12, 0x12, 0x42, 0x3e, 0x00, 0x00 } }, > > > > + { "266", "CPU: 266 PLB: 133 OPB: 66 EBC: 44 PCI: 44/66", > > > > + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > > > + 0x00, 0x50, 0x22, 0x2d, 0x42, 0x3e, 0x00, 0x00 } }, > > > > + { "333", "CPU: 333 PLB: 111 OPB: 55 EBC: 55 PCI: 55/111", > > > > + { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > > > + 0x00, 0x60, 0x29, 0x2d, 0x42, 0xbe, 0x00, 0x00 } }, > > > > +}; > > > > > > Indentation by TAB , please. > > > > I don't see a problem here. The code is aligned to the lines above via spaces > > (< 8 spaces). Example: > > The braces should be indented by TABs. Can you please post a suggestion you you would like to this these lines indented. When I try to replace the spaces by TABs, the code looks very ugly and unreadable and I don't like that. So perhaps I missed what you mean and I have to reconfigure my emacs autoindent mode to wd'mode. Matthias > > > { 0x19, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > ^^^^ > > > > The "0x00" is aligned using two spaces to the "0x19" above. Nothing wrong with > > it. > > Indentation is not done by TABs, but by TABs + spaces, and this is > wrong. > > Best regards, > > Wolfgang Denk >