From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Fri, 24 Jul 2009 00:55:08 +0200
Subject: [U-Boot] [PATCH v3] Add support for Eukrea CPUAT91 SBC
In-Reply-To: <20090723224105.A1C4E832E416@gemini.denx.de>
References: <20090718203217.DFF7A832E416@gemini.denx.de>
	<1247954953-10146-1-git-send-email-eric@eukrea.com>
	<20090723222713.GC24893@game.jcrosoft.org>
	<20090723224105.A1C4E832E416@gemini.denx.de>
Message-ID: <20090723225508.GE28766@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 00:41 Fri 24 Jul     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <20090723222713.GC24893@game.jcrosoft.org> you wrote:
> >
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -2683,6 +2683,18 @@ at91rm9200ek_config	:	unconfig
> > >  cmc_pu2_config	:	unconfig
> > >  	@$(MKCONFIG) $(@:_config=) arm arm920t cmc_pu2 NULL at91rm9200
> > >  
> > > +cpuat91_ram_config \
> > > +cpuat91_config	:	unconfig
> > > +	@mkdir -p $(obj)include
> > > +	@if [ "$(findstring _ram_,$@)" ] ; then \
> > > +		echo "#define CONFIG_CPUAT91_RAM 1" >>$(obj)include/config.h ; \
> > same as other patch
> > no need please define the
> > #define CONFIG_SKIP_LOWLEVEL_INIT
> > #define CONFIG_SKIP_RELOCATE_UBOOT
> > here
> 
> No. Not here, i. e. not in the Makefile. We don't want tens of lines
> of scripts per board in the top level Makefile.
I still do not want to see a new board specific config for this
specially when we do have already config for this

Best Regards,
J.