Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUpr2-0000My-Rz for qemu-devel@nongnu.org; Sat, 25 Jul 2009 18:36:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUpqx-0000IX-V1 for qemu-devel@nongnu.org; Sat, 25 Jul 2009 18:36:36 -0400 Received: from [199.232.76.173] (port=34186 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUpqx-0000IK-NH for qemu-devel@nongnu.org; Sat, 25 Jul 2009 18:36:31 -0400 Received: from mail.gmx.net ([213.165.64.20]:45085) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1MUpqx-0003JC-5q for qemu-devel@nongnu.org; Sat, 25 Jul 2009 18:36:31 -0400 From: "Jan-Simon =?utf-8?q?M=C3=B6ller?=" Subject: Re: [Qemu-devel] [PATCH 1/7] linux-user: dup3, fallocate syscalls Date: Sun, 26 Jul 2009 00:37:11 +0200 References: <1248455432-12959-1-git-send-email-uli@suse.de> <1248455432-12959-2-git-send-email-uli@suse.de> In-Reply-To: <1248455432-12959-2-git-send-email-uli@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200907260037.11900.dl9pf@gmx.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: riku.voipio@iki.fi Am Freitag 24 Juli 2009 19:10:26 schrieb Ulrich Hecht: > +#if defined(CONFIG_FALLOCATE) && defined(TARGET_NR_fallocate) > + =C2=A0 =C2=A0case TARGET_NR_fallocate: > + =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D get_errno(fallocate(arg1, arg2, arg3= , arg4)); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0break; > +#endif This might need checking for the glibc version, of it will fail to build e.= g.=20 on FC11 or with "older" glibc. See https://bugzilla.redhat.com/show_bug.cgi?id=3D500487 buildlog: LINK i386-linux-user/qemu-i386 /usr/lib/gcc/i586-redhat-linux/4.4.0/../../../libpthread.a(libpthread.o): I= n=20 function `sem_open': (.text+0x69da): warning: the use of `mktemp' is dangerous, better use=20 `mkstemp' /usr/bin/ld: Dwarf Error: Offset (9067) greater than or equal to .debug_str= =20 size (7930). syscall.o: In function `do_syscall': /home/abuild/rpmbuild/BUILD/qemu-0.11git2009.07.24.0516/linux-user/syscall.= c:6989:=20 undefined reference to `fallocate64' collect2: ld returned 1 exit status make[1]: *** [qemu-i386] Error 1 make: *** [subdir-i386-linux-user] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.Tjmyt9 (%build) Best, Jan-Simon