From: Jean-Christophe PLAGNIOL-VILLARD Date: Mon, 3 Aug 2009 14:17:48 +0200 Subject: [U-Boot] [PATCH] imx27lite: add support for imx27lite board from LogicPD In-Reply-To: <20090803081938.798878340728@gemini.denx.de> References: <20090723213757.GC9480@game.jcrosoft.org> <1249263981-14756-1-git-send-email-yanok@emcraft.com> <20090803053218.GA15665@game.jcrosoft.org> <20090803081938.798878340728@gemini.denx.de> Message-ID: <20090803121748.GG15665@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10:19 Mon 03 Aug , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20090803053218.GA15665@game.jcrosoft.org> you wrote: > > > ... > > > +/* malloc() len */ > > > +#define CONFIG_SYS_MALLOC_LEN (0x10000 + 256 * 1024) > > please do not mix hexa and decimal I've as there is other think to fix otherwise I'll not have ask > > Please be reasonable. This is a perfectly valid and easy to read > notation. I see no reason to change this - anything else would > probably be much harder to read. > > > > +#define CONFIG_LOADADDR 0xa0800000 /* loadaddr env var */ > > > +#define CONFIG_SYS_LOAD_ADDR CONFIG_LOADADDR > > why 2? > > Because they do different things. I've take a look they do nearly the same think it will be better to avoid have 2 configs specialy when there are the same btw I've found nothing about it in the README Best Regards, J.