From: Jean-Christophe PLAGNIOL-VILLARD Date: Sat, 8 Aug 2009 17:00:08 +0200 Subject: [U-Boot] [PATCH v2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache In-Reply-To: <4A7D8D22.2090902@googlemail.com> References: <1249728369-2738-1-git-send-email-dirk.behme@googlemail.com> <20090808112611.GW13346@game.jcrosoft.org> <4A7D81FF.9020404@googlemail.com> <20090808141059.GX13346@game.jcrosoft.org> <4A7D8D22.2090902@googlemail.com> Message-ID: <20090808150008.GC17045@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 16:35 Sat 08 Aug , Dirk Behme wrote: > Jean-Christophe PLAGNIOL-VILLARD wrote: > >On 15:47 Sat 08 Aug , Dirk Behme wrote: > >>Jean-Christophe PLAGNIOL-VILLARD wrote: > >>>On 12:46 Sat 08 Aug , Dirk Behme wrote: > >>>>Since there is only one version of flushing the dcache for > >>>>arm_cortex8, rename v7_flush_dcache_all to the the generic > >>>>name flush_dcache. Because the function is intended for > >>>>only omap3 boards, move the function to the new file > >>>>cache_flush.S. > >>>> > >>>>Signed-off-by: Tom Rix > >>>>Signed-off-by: Dirk Behme > >>>>--- > >>>NACK keep the arm arch version in the name > >>NACK the NACK, see below. > >> > >>>and as request to Tom remove the non need device_type > >>>and we can safely use the v7 cache flush for omap3 and other cortex a8 > >>This can be done easily (later?) by an additional patch (when people > >>have time for it?). > >> > >>Applying the basic functionality (function move) now allows others > >>to finally go on with their long waiting patches. > >no this code is omap3 specific and there is no need ot this > >rename or move the function make no sense > > Yes, it is OMAP3 specific (as already mentioned in the patch > description). So it's totally fine to move it to an OMAP3 specific > file. So it's totally fine that others (!= OMAP3, e.g Samsung) can > re-use arm_cortexa8 stuff without the burden of OMAP3 stuff. the flush MUST NOT be soc specific as there is NO need to do this at all so NACK Best Regards, J.