From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] Re: virtio-blk performance and MSI Date: Sun, 9 Aug 2009 22:53:45 +0300 Message-ID: <20090809195345.GA21703@redhat.com> References: <20090806163549.GA25594@lst.de> <4A7E9E7F.2090901@redhat.com> <20090809174100.GA17096@lst.de> <4A7F0C23.8070807@redhat.com> <20090809191313.GA23446@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mx2.redhat.com ([66.187.237.31]:36819 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753365AbZHITy6 (ORCPT ); Sun, 9 Aug 2009 15:54:58 -0400 Content-Disposition: inline In-Reply-To: <20090809191313.GA23446@lst.de> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Aug 09, 2009 at 09:13:13PM +0200, Christoph Hellwig wrote: > On Sun, Aug 09, 2009 at 08:49:23PM +0300, Avi Kivity wrote: > > Sorry, confused. Upstream doesn't use kvm for msi (everything's done in > > userspace). What exactly blocks us here? > > Hmm, good question. Michael, do you know if we can just enabled > MSI unconditionally in upstream qemu, or are there guests that can't > cope with it? Upstream or not, block should request MSI by default, the code in hw/msi checks that host kernel can support it and only enables when it's safe. And AFAIK all guests can cope with it but only if they are rebooted. So we must have a flag to change the # of vectors, to have ability to load images and migrate from state stored by old qemu. And of course this option is also useful for troubleshooting. -- MST