From: Wolfgang Denk <wd@denx.de>
Date: Sun, 09 Aug 2009 22:09:40 +0200
Subject: [U-Boot] [PATCH v5] Add support for Eukrea CPUAT91 SBC
In-Reply-To: <1249816414-18989-1-git-send-email-eric@eukrea.com>
References: <20090801094026.GC2637@game.jcrosoft.org>
	<1249816414-18989-1-git-send-email-eric@eukrea.com>
Message-ID: <20090809200940.797A4833DBD2@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Eric Benard,

In message <1249816414-18989-1-git-send-email-eric@eukrea.com> you wrote:
> CPUAT91 is built around Atmel's AT91RM9200 and has up to 16MB of NOR
> flash, up to 128MB of SDRAM, and includes a Micrel KS8721 PHY in RMII
> mode.
...
> +cpuat91_ram_config \
> +cpuat91_config	:	unconfig
> +	@mkdir -p $(obj)include
> +	@if [ "$(findstring _ram_,$@)" ] ; then \
> +		echo "#define CONFIG_SKIP_LOWLEVEL_INIT" >> $(obj)include/config.h; \
> +		echo "#define CONFIG_SKIP_RELOCATE_UBOOT" >> $(obj)include/config.h; \
> +		$(XECHO) "... CPUAT91 configured for RAM" ; \
> +	else \
> +		echo "#define CONFIG_BOOTDELAY 1" >>$(obj)include/config.h ; \
> +		$(XECHO) "... CPUAT91 configured for Flash" ;\
> +	fi;
> +	@$(MKCONFIG) -a cpuat91 arm arm920t cpuat91 eukrea at91rm9200
> +
>  csb637_config	:	unconfig
>  	@$(MKCONFIG) $(@:_config=) arm arm920t csb637 NULL at91rm9200

Please do not add such scripting to the top level Makefile. Perform it
in your board config file instead.

For an example, please see 
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/65499

> +unsigned char ks8721_autonegotiate(AT91PS_EMAC p_mac, int *status)
> +{
...
> +	/* Set the Auto_negotiation Advertisement Register */
> +	/* MII advertising for Next page, 100BaseTxFD and HD, */
> +	/* 10BaseTFD and HD, IEEE 802.3 */

Incorrect multiline comment style.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Madness has no purpose.  Or reason.  But it may have a goal.
	-- Spock, "The Alternative Factor", stardate 3088.7