From: Jean-Christophe PLAGNIOL-VILLARD Date: Wed, 12 Aug 2009 23:03:39 +0200 Subject: [U-Boot] [PATCH 1/3] net/eth_device: keep index inside each device In-Reply-To: <20090812185054.63898833DBD2@gemini.denx.de> References: <1250023747-20224-1-git-send-email-plagnioj@jcrosoft.com> <20090812185054.63898833DBD2@gemini.denx.de> Message-ID: <20090812210339.GE21725@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 20:50 Wed 12 Aug , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <1250023747-20224-1-git-send-email-plagnioj@jcrosoft.com> you wrote: > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > --- > > include/net.h | 1 + > > net/eth.c | 17 +++++------------ > > 2 files changed, 6 insertions(+), 12 deletions(-) > > What exactly is the problem you are addressing with this patch? > > Please provide a commit message that explains what is going on, and > what is being changed or fixed. simple it impossible to known what will be your device index in the driver specially when you have 2 or more drivers instance once or more so you can not update the mac addres in the env if you want to do it as we do on smc91111 as we can not known eth%daddr you are which allow us the avoid to read the eeprom every time we want to use the eth Best Regards, J.