From: Christoph Egger Subject: [PATCH] xen: xen-debug is too noisy Date: Fri, 14 Aug 2009 11:44:24 +0200 Message-ID: <200908141144.24410.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-00=_4HThKRH6+E2Q8FD" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --Boundary-00=_4HThKRH6+E2Q8FD Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi! On guest MCE read only print debug code when a non-zero value has been read. Xen is too noisy, otherwise. Signed-off-by: Christoph Egger -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 --Boundary-00=_4HThKRH6+E2Q8FD Content-Type: text/x-diff; charset="us-ascii"; name="xen_mce.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xen_mce.diff" diff -r f4601471c59b xen/arch/x86/cpu/mcheck/mce.c --- a/xen/arch/x86/cpu/mcheck/mce.c Fri Aug 14 08:36:12 2009 +0100 +++ b/xen/arch/x86/cpu/mcheck/mce.c Fri Aug 14 10:58:49 2009 +0200 @@ -685,7 +685,9 @@ int mce_rdmsr(u32 msr, u32 *lo, u32 *hi) case MSR_IA32_MCG_STATUS: *lo = (u32)d->arch.vmca_msrs.mcg_status; *hi = (u32)(d->arch.vmca_msrs.mcg_status >> 32); - gdprintk(XENLOG_DEBUG, "MCE: rd MCG_STATUS lo %x hi %x\n", *lo, *hi); + if (*lo || *hi) + gdprintk(XENLOG_DEBUG, + "MCE: rdmsr MCG_STATUS lo %x hi %x\n", *lo, *hi); break; case MSR_IA32_MCG_CAP: *lo = (u32)d->arch.vmca_msrs.mcg_cap; @@ -710,7 +712,7 @@ int mce_rdmsr(u32 msr, u32 *lo, u32 *hi) case MSR_IA32_MC0_CTL: *lo = (u32)d->arch.vmca_msrs.mci_ctl[bank]; *hi = (u32)(d->arch.vmca_msrs.mci_ctl[bank] >> 32); - gdprintk(XENLOG_DEBUG, "MCE: rd MC%u_CTL lo %x hi %x\n", + gdprintk(XENLOG_DEBUG, "MCE: rdmsr MC%u_CTL lo %x hi %x\n", bank, *lo, *hi); break; case MSR_IA32_MC0_STATUS: @@ -729,8 +731,6 @@ int mce_rdmsr(u32 msr, u32 *lo, u32 *hi) else entry = NULL; } - if ( !entry ) - gdprintk(XENLOG_DEBUG, "MCE: rd MC%u_STATUS\n", bank); break; case MSR_IA32_MC0_ADDR: if ( !list_empty(&d->arch.vmca_msrs.impact_header) ) @@ -826,7 +826,7 @@ int mce_wrmsr(u32 msr, u64 value) list_del(&entry->list); } else - gdprintk(XENLOG_DEBUG, "MCE: Not found HVM guest" + gdprintk(XENLOG_WARNING, "MCE: Not found HVM guest" " last injection Node, something Wrong!\n"); } break; --Boundary-00=_4HThKRH6+E2Q8FD Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-00=_4HThKRH6+E2Q8FD--