From: Frans Pop Subject: [PATCH,resend] acpi processor: simplify needlessly complex printk Date: Mon, 17 Aug 2009 14:51:43 +0200 Message-ID: <200908171451.44732.elendil@planet.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from cpsmtpm-eml105.kpnxchange.com ([195.121.3.9]:54656 "EHLO CPSMTPM-EML105.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbZHQMvo (ORCPT ); Mon, 17 Aug 2009 08:51:44 -0400 Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: linux-acpi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Len Brown Why use three printk statements if one will do? Also makes it easier to grep for the string. Signed-off-by: Frans Pop diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c index 84e0f3c..b8fb74a 100644 --- a/drivers/acpi/processor_core.c +++ b/drivers/acpi/processor_core.c @@ -772,12 +772,11 @@ static int __cpuinit acpi_processor_start(struct acpi_device *device) if (result) printk(KERN_ERR PREFIX "Create sysfs link\n"); - if (pr->flags.throttling) { - printk(KERN_INFO PREFIX "%s [%s] (supports", - acpi_device_name(device), acpi_device_bid(device)); - printk(" %d throttling states", pr->throttling.state_count); - printk(")\n"); - } + if (pr->flags.throttling) + printk(KERN_INFO PREFIX + "%s [%s] (supports %d throttling states)\n", + acpi_device_name(device), acpi_device_bid(device), + pr->throttling.state_count); end: