From: Wolfgang Denk <wd@denx.de>
Date: Mon, 17 Aug 2009 22:42:27 +0200
Subject: [U-Boot] [PATCH] Adding support for DevKit8000
In-Reply-To: <4A897571.9090404@googlemail.com>
References: <1250500736-20034-1-git-send-email-frederik@kriewitz.eu>
	<4A897571.9090404@googlemail.com>
Message-ID: <20090817204227.D3CAB833DBD2@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Dirk Behme,

In message <4A897571.9090404@googlemail.com> you wrote:
> 
> Wolfgang commented already most of the topics.

:-)

> So, only one comment left for me:

But a well spottet one, thanks!

> > +	/* Use OMAP DIE_ID as MAC address */
> > +	if (!eth_getenv_enetaddr("ethaddr", enetaddr)) {
> > +		enetaddr[0] = 0x02; /* locally administered */
> > +		enetaddr[1] = readl(&id_base->die_id_1) & 0xff;
> > +		*(u32*)&enetaddr[2] = readl(&id_base->die_id_0);

Who guarantess that &enetaddr[2] will be 32 bit aligned?
And hat does this machine do on unaligned accesses?

Frederik: Please fix this.

> > +		eth_setenv_enetaddr("ethaddr", enetaddr);
> > +	}
> 
> With the OMAP DIE_ID thread we know what you are doing here. But do we 
> want to have this really in mainline? It looks to me like a workaround 
> for broken hardware (that is, having no proper MAC address 
> configured)? Or do I miss anything?

Indeed. It's fishy at best.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When the tide of life turns against you
And the current upsets your boat
Don't waste tears on what might have been
Just lie on your back and float.