From: Wolfgang Denk Date: Tue, 18 Aug 2009 14:53:16 +0200 Subject: [U-Boot] [PATCH v2 1/2] tools: mkimage: Fixed build warnings In-Reply-To: <20090818122223.73095833DBD2@gemini.denx.de> References: <1250380700-15636-1-git-send-email-prafulla@marvell.com> <20090818122223.73095833DBD2@gemini.denx.de> Message-ID: <20090818125316.4FF77833DBD2@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Prafulla, In message <20090818122223.73095833DBD2@gemini.denx.de> I wrote: > > In message <1250380700-15636-1-git-send-email-prafulla@marvell.com> you wrote: > > uninitialized retval variable warning fixed > > crc32 APIs moved to crc.h (newly added) and build warnings fixed > > some indentation tabs fixed > > > > Signed-off-by: Prafulla Wadaskar > > --- > > Change log: > > v2: updated as per review feedback for v1 > > > > include/common.h | 4 +--- > > include/u-boot/crc.h | 33 +++++++++++++++++++++++++++++++++ > > tools/mkimage.c | 20 +++++++++++--------- > > 3 files changed, 45 insertions(+), 12 deletions(-) > > create mode 100644 include/u-boot/crc.h > > Applied to "mkimage" branch. > > I decided to omit the tab cleanup, and used "uchar" instead of > "unsigned char" so no reformatting due to growing line length was > needed. This way the changes are (IMHO) better visible. ...what a stupid idea. I didn't consider that "uchar" might not be defined in standard compile environments. Undone. I applied your original patch now, just with minimal indentation changes. Sorry for the confusion. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I usually tell my classes "if you are using @ and [] together in this class, you will almost certainly NOT get what you want. That's going down the wrong tunnel. There's no cheese at the end of that tunnel." -- Randal L. Schwartz in <8czptuomey.fsf@gadget.cscaper.com>