From: Simon Kagstrom <simon.kagstrom@netinsight.net>
Date: Fri, 21 Aug 2009 08:05:47 +0200
Subject: [U-Boot] [PATCH v2 1/4]: Move __set/clear_bit from ubifs.h to
 bitops.h
In-Reply-To: <200908201344.37190.vapier@gentoo.org>
References: <20090820104944.42dbeca7@marrow.netinsight.se>
	<20090820105250.191c7ce9@marrow.netinsight.se>
	<200908201344.37190.vapier@gentoo.org>
Message-ID: <20090821080547.22c8d94d@marrow.netinsight.se>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, 20 Aug 2009 13:44:35 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> On Thursday 20 August 2009 04:52:50 Simon Kagstrom wrote:
> > --- a/include/asm-sh/bitops.h
> > +++ b/include/asm-sh/bitops.h
> > @@ -146,6 +146,11 @@ static inline int ffs (int x)
> >  	}
> >  	return r;
> >  }
> > +
> > +#define __set_bit(nr, addr) generic_set_bit(nr, addr)
> > +
> > +#define __clear_bit(nr, addr) generic_clear_bit(nr, addr)
> 
> this is just silly to put into every arch header.  why not do in the common 
> code:
> #ifndef __set_bit
> # define __set_bit generice_set_bit
> #endif

It's a function (static inline) in some architectures.

// Simon