From: Pasi =?iso-8859-1?Q?K=E4rkk=E4inen?= Subject: Re: [PATCH]: Implement bzip2 and LZMA loaders / fixed patch for Xen 3.4.1 Date: Fri, 21 Aug 2009 12:22:43 +0300 Message-ID: <20090821092243.GL19938@edu.joroinen.fi> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Chris Lalancette , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Thu, Aug 20, 2009 at 10:27:29PM +0100, Keir Fraser wrote: > On 20/08/2009 22:15, "Keir Fraser" wrote: > > >> Hmm, actually this patch seems to break stubdom build/linking: > > > > I checked in a variant as c/s 20103, which at least for non-stubdom build of > > libxenguest should do the right thing if liblzma-devel or libbz2-devel > > packages (or whatever they are called) are not installed. See how that goes > > with stubdom. We may just have to massage the Makefile a little more to kill > > off the bz2/lzma stuff for stubdom. I'm not sure why libxenguest is getting > > built for stubdom in the first place though. It's not likely to be very > > useful! > > Okay, I tested and fixed the stubdom case, so hopefully c/s 20104 will > actually work for you. > xen-unstable "make tools && make stubdom" compiles for me with and without libbz2-devel/liblzma-devel installed. But even when I have liblzma-devel installed it doesn't seem to use it. ie. I only see -DHAVE_BZLIB in the build log and libxenguest.so.3.4.0 gets only linked against -lbz2. Investigating more.. -- Pasi