Date: Fri, 21 Aug 2009 16:50:48 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 0/2] native Linux AIO support revisited
Message-ID: <20090821145048.GB22645@lst.de>
References: <20090820145803.GA23578@lst.de> <4A8E4F87.6070405@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A8E4F87.6070405@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On Fri, Aug 21, 2009 at 10:40:55AM +0300, Avi Kivity wrote:
> On 08/20/2009 05:58 PM, Christoph Hellwig wrote:
> >Based on this I would recommend to include this patch, but not use it by
> >default for now.  After some testing I would suggest to enable it by
> >default for host devices and investigate a way to make it easily usable
> >for files, possibly including some kernel support to tell us which files
> >are "safe".
> >   
> 
> I like both the numbers and the patches.  But why disable by default?  
> Enabling for cache=none host devices only seems a safe choice.

I want to 

  a) get some more testing.  Especially from people who are better at
     testing than me and have a wider variety of hardware
  b) sort out the queue depth issue.  Which I'd really prefer to once
     the basic patch is in I don't have to work with a large patch
     stack.