Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MfZ9Q-0001LW-SJ for mharc-grub-devel@gnu.org; Mon, 24 Aug 2009 08:59:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MfZ9P-0001Jy-Dd for grub-devel@gnu.org; Mon, 24 Aug 2009 08:59:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MfZ9K-0001E2-M2 for grub-devel@gnu.org; Mon, 24 Aug 2009 08:59:54 -0400 Received: from [199.232.76.173] (port=51425 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MfZ9K-0001Dl-Ga for grub-devel@gnu.org; Mon, 24 Aug 2009 08:59:50 -0400 Received: from smarthost03.mail.zen.net.uk ([212.23.3.142]:57134) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MfZ9J-0001c6-I0 for grub-devel@gnu.org; Mon, 24 Aug 2009 08:59:49 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost03.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1MfZ9I-0000EY-AA for grub-devel@gnu.org; Mon, 24 Aug 2009 12:59:48 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1MfZ9H-0006Bu-00; Mon, 24 Aug 2009 13:59:47 +0100 Date: Mon, 24 Aug 2009 13:59:47 +0100 From: Colin Watson To: The development of GRUB 2 Message-ID: <20090824125947.GF11691@riva.ucam.org> Mail-Followup-To: The development of GRUB 2 References: <20090812153520.GA11691@riva.ucam.org> <20090823222745.GA25665@thorin> <20090824091109.GC11691@riva.ucam.org> <20090824115726.GA18956@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090824115726.GA18956@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost03-IP: [82.69.40.219] X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Detect key modifier status in 'sleep --interruptible' X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2009 12:59:55 -0000 On Mon, Aug 24, 2009 at 01:57:26PM +0200, Robert Millan wrote: > On Mon, Aug 24, 2009 at 10:11:10AM +0100, Colin Watson wrote: > > No, that code only spots make scan codes arriving after GRUB's terminal > > starts up. AFAICS it has no way to tell whether e.g. Shift was held down > > already when GRUB started > > Ah, you're right on this.. > > > (except through the vagaries of key repeat), > > ..but on this too. Why not check for key repeat? The controller generates > them for all keys AFAIK. If you want a delay of zero (i.e. "is Shift pressed? no? OK, boot immediately with no delay"), how long should you wait for key repeat? If there's a sensible answer to that question (IIRC key repeat speed is sometimes configurable in the BIOS) then we could do that ... -- Colin Watson [cjwatson@ubuntu.com]