From: Mike Frysinger Date: Thu, 27 Aug 2009 03:22:49 -0400 Subject: [U-Boot] [PATCH 3/7] eSPI: add eSPI controller support In-Reply-To: <73839B4A0818E747864426270AC332C304438093@zmy16exm20.fsl.freescale.net> References: <1237171943-11938-1-git-send-email-Mingkai.hu@freescale.com> <200908270243.23967.vapier@gentoo.org> <73839B4A0818E747864426270AC332C304438093@zmy16exm20.fsl.freescale.net> Message-ID: <200908270322.50668.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 27 August 2009 02:59:34 Hu Mingkai-B21284 wrote: > From: Mike Frysinger [mailto:vapier at gentoo.org] > > On Thursday 27 August 2009 02:27:30 Hu Mingkai-B21284 wrote: > > > > but what if you dont know the length of the transaction ahead of > > > > time ? if you look at the spi flash framework, it'll write a few > > > > bytes (like the opcode to read the status > > > > register) and then it'll just keep reading 1 byte at a time (polling > > > > the status register). there is no way of knowing the length ahead > > > > of time. most of the SPI code in u-boot operates this way. > > > > > > So the driver use the length passed by SPI flash read function. > > > If the length is greater than the max value that is limited by the > > > transaction length register's bitfiled, the driver couldn't read > > > anything. > > > > the length used by the first read covers just the length of > > the opcode, not any of the data returned by the part > > > > as long as your driver rejects all of these things, it'll be > > detected at runtime and it should be fine to merge -mike > > So the driver combine the opcode length and the data length together, > then pass to spi_xfer(for eSPI) . When return the read results, skip the > first opcode length bytes. you dont get it ... there is no data length. the code does: spi_write(~3 bytes for opcode, BEGIN flag); while (1) { spi_read(read 1 data byte); check_result(); } end_spi_transaction(); there is no "data length" which means your controller cannot support the SPI flash framework -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090827/bbe109b0/attachment.pgp