Date: Mon, 31 Aug 2009 16:00:20 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] savevm: Convert loadvm handlers list
	to LIST
Message-ID: <20090831160020.3799813c@doriath>
In-Reply-To: <c9dabedcdce60a1883531a9808e8fcbb72545456.1251491268.git.quintela@redhat.com>
References: <cover.1251491268.git.quintela@redhat.com>
	<c9dabedcdce60a1883531a9808e8fcbb72545456.1251491268.git.quintela@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
To: Juan Quintela <quintela@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Fri, 28 Aug 2009 22:31:57 +0200
Juan Quintela <quintela@redhat.com> wrote:

> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  savevm.c |   20 +++++++++++---------
>  1 files changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/savevm.c b/savevm.c
> index baef277..9836c60 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1260,10 +1260,10 @@ static SaveStateEntry *find_se(const char *idstr, int instance_id)
>  }
> 
>  typedef struct LoadStateEntry {
> +    LIST_ENTRY(LoadStateEntry) entry;
>      SaveStateEntry *se;
>      int section_id;
>      int version_id;
> -    struct LoadStateEntry *next;
>  } LoadStateEntry;
> 
>  static int qemu_loadvm_state_v2(QEMUFile *f)
> @@ -1309,7 +1309,8 @@ static int qemu_loadvm_state_v2(QEMUFile *f)
> 
>  int qemu_loadvm_state(QEMUFile *f)
>  {
> -    LoadStateEntry *first_le = NULL;
> +    LIST_HEAD(, LoadStateEntry) loadvm_handlers;

 You're missing the initialization here, spot this while
testing staging.