From: sleep_walker@suse.cz (=?utf-8?q?Tom=C3=A1=C5=A1_=27Sleep=5FWalker=27?=
	=?utf-8?q?_=C4=8Cech?=)
Date: Tue, 1 Sep 2009 22:50:26 +0200
Subject: [PATCH 4/5] PalmGSM: generalisation of Treo680 code to PalmGSM
In-Reply-To: <4A9CEBE3.6090203@gmail.com>
References: <1251333811-22360-1-git-send-email-sleep_walker@suse.cz>
	<200909010322.49142.marek.vasut@gmail.com>
	<4A9CEBE3.6090203@gmail.com>
Message-ID: <200909012250.26395.sleep_walker@suse.cz>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi,

Dne ?t 1. z??? 2009 11:39:47 Eric Miao napsal(a):
> Marek Vasut wrote:
> > Dne ?t 1. z??? 2009 02:07:16 Pavel Machek napsal(a):
> >> Ahoj! / Hi!
> > Ahoj! / Hi! / Guten Tag!
> >>>>>>> arch/arm/mach-pxa/Kconfig                |    5 +
> >>>>>>> arch/arm/mach-pxa/Makefile               |    2 +-
> >>>>>>> arch/arm/mach-pxa/include/mach/palmgsm.h |   60 ++++
> >>>>>>> arch/arm/mach-pxa/include/mach/treo680.h |   49 ---
> >>>>>>> arch/arm/mach-pxa/palmgsm.c              |  559
> >>>>>>> ++++++++++++++++++++++++++++++ arch/arm/mach-pxa/treo680.c       
> >>>>>>>       |  528 ----------------------------
> >>>>>> I don't actually care too much about the naming - as long as 685
> >>>>>> can stay within treo680.c, I don't see any problem with that. The
> >>>>>> real question is: is palmgsm.c the proper name for all these
> >>>>>> devices?
> >>>>> Well, actually your completely right. PalmGSM is not fitting for all
> >>>>> devices to come, more fitting would be something like Palm
> >>>>> smartphones because there are CDMA devices to come too. On the other
> >>>>> hand, this name is the best I found so far. If you don't mind I would
> >>>>> even so...
> >>>> I believe treo680 was better name then. Don't change it if you don't
> >>>> need to...
> >>> But I need to have different generic name - treo680 will be occupied by
> >>> Treo680 specific stuff, which makes more sense, doesn't it?
> >> And rename generic code to treo.c? Then you could have treo.c for
> >> generic code, and treo680.c / treo685.c for specific models...
> >>
> >> palmgsm.c sounds like driver for their GSM chip...
> >> 									Pavel
> > 
> > Yeah, or treo-common.c in case you'd want to split it into core file + model 
> > files. But treo.c/palm(smart)phone.c (?) seems more ok. I dont like the idea of 
> > splitting the code into more files (one big, and many small).
> > 
> 
> Well, treo680.c can just include all the specific stuffs in a single
> file as long as possibility is concerned. And #ifdef .. #endif can
> be used to include the code or not. See ezx.c for a good example.

Well, I think I follow ezx.c example as much as I can - or it wasn't addressed to me?

Best regards,

Tomas Cech