From: Jean-Christophe PLAGNIOL-VILLARD Date: Sun, 6 Sep 2009 15:48:39 +0200 Subject: [U-Boot] [PATCH 4/8] OMAP3 Add usb device support In-Reply-To: <4AA3BA8A.5030603@windriver.com> References: <1252095170-5492-1-git-send-email-Tom.Rix@windriver.com> <1252095170-5492-2-git-send-email-Tom.Rix@windriver.com> <1252095170-5492-3-git-send-email-Tom.Rix@windriver.com> <1252095170-5492-4-git-send-email-Tom.Rix@windriver.com> <20090905002527.GA30118@game.jcrosoft.org> <4AA3BA8A.5030603@windriver.com> Message-ID: <20090906134839.GH18844@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > >>+ } > >>+ > >>+ if (debug_setup && (debug_level > 1)) > >>+ musb_db_regs(); > >>+} > >>+ > >>+static void musb_peri_reset(void) > >>+{ > >>+ if ((debug_setup) && (debug_level > 1)) > >>+ serial_printf("INFO : %s reset\n", __PRETTY_FUNCTION__); > >what do you mean y __PRETTY_FUNCTION__? > This a gcc compiler macro for printing out the function of the calling > routine. It is useful in the macro's like the state machine changer > to show which function did the change instead of the usual > __LINE__ + __FILE__ + eyeball time. It is a non-standard cpp macro > and would bite us when compiling without gcc. Does u-boot build > with non-gcc ? no only gcc but I think it will not be impossible to use an other toolchains but ok > >>+ > >>+ /* the device address is reset by the event */ > >>diff --git a/include/usb.h b/include/usb.h > >>index 378a23b..198d5bb 100644 > >>--- a/include/usb.h > >>+++ b/include/usb.h > >>@@ -131,7 +131,8 @@ struct usb_device { > >> #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \ > >> defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \ > >> defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \ > >>- defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) > >>+ defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) || \ > >>+ defined(CONFIG_USB_OMAP3) > >a simple CONFIG will be better > Can this be a follow-on ? ofcource Best Regards, J.