Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MlpC1-0003kI-FZ for mharc-grub-devel@gnu.org; Thu, 10 Sep 2009 15:20:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MlpBz-0003id-Tk for grub-devel@gnu.org; Thu, 10 Sep 2009 15:20:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MlpBu-0003hC-Ab for grub-devel@gnu.org; Thu, 10 Sep 2009 15:20:26 -0400 Received: from [199.232.76.173] (port=58765 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MlpBu-0003h0-84 for grub-devel@gnu.org; Thu, 10 Sep 2009 15:20:22 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:48014 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MlpBt-0002r7-RN for grub-devel@gnu.org; Thu, 10 Sep 2009 15:20:22 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MlpBr-000757-VU for grub-devel@gnu.org; Thu, 10 Sep 2009 21:20:20 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MlpBr-0004ze-3c for grub-devel@gnu.org; Thu, 10 Sep 2009 21:20:19 +0200 Date: Thu, 10 Sep 2009 21:20:19 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090910192019.GE18736@thorin> References: <20090910153729.GA13423@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090910153729.GA13423@riva.ucam.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Don't try to use help2man when cross-compiling X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2009 19:20:28 -0000 On Thu, Sep 10, 2009 at 04:37:29PM +0100, Colin Watson wrote: > John Taylor reported that this patch fixes one of his problems in > http://savannah.gnu.org/bugs/?27349. It's been a while since I had > anything to do with Autoconf's cross-compiling support, so does this > look reasonable? The "cross_compiling" variable was added in a > considerably older version of Autoconf than we already require. > > 2009-09-10 Colin Watson > > * configure.ac: Don't look for help2man when cross-compiling. Fixes > part of bug #27349. > > Index: configure.ac > =================================================================== > --- configure.ac (revision 2584) > +++ configure.ac (working copy) > @@ -147,7 +147,9 @@ > > # These are not a "must". > AC_PATH_PROG(RUBY, ruby) > -AC_PATH_PROG(HELP2MAN, help2man) > +if test "x$cross_compiling" = xno; then > + AC_PATH_PROG(HELP2MAN, help2man) > +fi Autoconf documentation says you can test for $cross_compiling being set to "yes", but is unclear about the variable being defined or not when we're not cross-compiling. Maybe we should test "x$cross_compiling" != xyes instead? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."