From: Christoph Hellwig Subject: Re: [PATCH 18/16] implement posix O_SYNC and O_DSYNC semantics Date: Thu, 10 Sep 2009 22:44:31 +0200 Message-ID: <20090910204431.GA20993@lst.de> References: <1251899966-7316-1-git-send-email-jack@suse.cz> <20090910202521.GA20261@lst.de> <1252615120.8722.148.camel@heimdal.trondhjem.org> <20090910204026.GA20797@lst.de> <1252615415.8722.150.camel@heimdal.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Jan Kara , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, drepper@redhat.com, viro@zeniv.linux.org.uk, kyle@mcmartin.ca To: Trond Myklebust Return-path: Received: from verein.lst.de ([213.95.11.210]:40843 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753845AbZIJUp2 (ORCPT ); Thu, 10 Sep 2009 16:45:28 -0400 Content-Disposition: inline In-Reply-To: <1252615415.8722.150.camel@heimdal.trondhjem.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Sep 10, 2009 at 04:43:35PM -0400, Trond Myklebust wrote: > > > > Doesn't matter, we check early in the open path that __O_SYNC is only > > set together with O_SYNC. > > Right, but (file->f_flags & O_SYNC) will be non-zero even if only the > O_DSYNC flag is set. Thanks, corrected.