Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mm5x4-0000vk-Hd for mharc-grub-devel@gnu.org; Fri, 11 Sep 2009 09:14:10 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mm5x0-0000tf-QS for grub-devel@gnu.org; Fri, 11 Sep 2009 09:14:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mm5ww-0000ql-43 for grub-devel@gnu.org; Fri, 11 Sep 2009 09:14:06 -0400 Received: from [199.232.76.173] (port=45390 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mm5wv-0000qc-Ni for grub-devel@gnu.org; Fri, 11 Sep 2009 09:14:01 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:53982 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mm5wv-0004MB-A6 for grub-devel@gnu.org; Fri, 11 Sep 2009 09:14:01 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mm5ws-0001a3-IE for grub-devel@gnu.org; Fri, 11 Sep 2009 15:13:58 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Mm5wr-00024Y-N6 for grub-devel@gnu.org; Fri, 11 Sep 2009 15:13:57 +0200 Date: Fri, 11 Sep 2009 15:13:57 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090911131357.GA7959@thorin> References: <20090910153729.GA13423@riva.ucam.org> <20090910192019.GE18736@thorin> <20090910225103.GE13423@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090910225103.GE13423@riva.ucam.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Don't try to use help2man when cross-compiling X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2009 13:14:07 -0000 On Thu, Sep 10, 2009 at 11:51:04PM +0100, Colin Watson wrote: > On Thu, Sep 10, 2009 at 09:20:19PM +0200, Robert Millan wrote: > > On Thu, Sep 10, 2009 at 04:37:29PM +0100, Colin Watson wrote: > > > Index: configure.ac > > > =================================================================== > > > --- configure.ac (revision 2584) > > > +++ configure.ac (working copy) > > > @@ -147,7 +147,9 @@ > > > > > > # These are not a "must". > > > AC_PATH_PROG(RUBY, ruby) > > > -AC_PATH_PROG(HELP2MAN, help2man) > > > +if test "x$cross_compiling" = xno; then > > > + AC_PATH_PROG(HELP2MAN, help2man) > > > +fi > > > > Autoconf documentation says you can test for $cross_compiling being set to > > "yes", but is unclear about the variable being defined or not when we're not > > cross-compiling. > > It's always set during initialisation. > > > Maybe we should test "x$cross_compiling" != xyes instead? > > This is probably a good idea anyway. AC_RUN_IFELSE just checks against > yes, so I think it's the right thing to do. Furthermore, if we move this > down to after the compiler checks then we get a more reliable test. > > Revised patch follows, also addressing Felix's comment. Is this better? Looks fine. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."