Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MmTav-0004L7-F6 for mharc-grub-devel@gnu.org; Sat, 12 Sep 2009 10:28:53 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MmTat-0004JV-JK for grub-devel@gnu.org; Sat, 12 Sep 2009 10:28:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MmTao-0004Go-4z for grub-devel@gnu.org; Sat, 12 Sep 2009 10:28:50 -0400 Received: from [199.232.76.173] (port=48996 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmTao-0004Gl-0Y for grub-devel@gnu.org; Sat, 12 Sep 2009 10:28:46 -0400 Received: from mx20.gnu.org ([199.232.41.8]:21143) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MmTan-0000mz-JQ for grub-devel@gnu.org; Sat, 12 Sep 2009 10:28:45 -0400 Received: from smarthost02.mail.zen.net.uk ([212.23.3.141]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MmNn2-0005Jf-Kh for grub-devel@gnu.org; Sat, 12 Sep 2009 04:17:00 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost02.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1MmNme-0006xb-In for grub-devel@gnu.org; Sat, 12 Sep 2009 08:16:36 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1MmNmd-0002yr-00; Sat, 12 Sep 2009 09:16:35 +0100 Date: Sat, 12 Sep 2009 09:16:35 +0100 From: Colin Watson To: The development of GRUB 2 Message-ID: <20090912081635.GJ13423@riva.ucam.org> References: <20090902110141.GR13423@riva.ucam.org> <20090903143323.GH6656@thorin> <20090903145243.GZ13423@riva.ucam.org> <20090903150859.GA18316@thorin> <1252705386.2616.3.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1252705386.2616.3.camel@mj> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost02-IP: [82.69.40.219] X-detected-operating-system: by mx20.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] save_env variable_name=value X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Sep 2009 14:28:52 -0000 On Fri, Sep 11, 2009 at 05:43:06PM -0400, Pavel Roskin wrote: > On Thu, 2009-09-03 at 17:08 +0200, Robert Millan wrote: > > Pavel, please comment on this when you can. It seems to me that doing it > > in grub-mkconfig would require less ad-hoc code in loadenv.mod and make it > > more efficient. > > I don't see how grub-mkconfig could compensate for a missing feature in > save_env. Perhaps I'm missing the context here. The choices are: var=value save_env var (uglier grub-mkconfig code, smaller core) save_env var=value (simpler grub-mkconfig, more code in core) -- Colin Watson [cjwatson@ubuntu.com]