From: Cyrill Gorcunov Subject: Re: [RFC][PATCH 08/10] x86: Don't ack_APIC_irq() if lapic is disabled in GENERIC_INTERRUPT_VECTOR handler Date: Wed, 16 Sep 2009 12:58:35 +0400 Message-ID: <20090916085835.GE5094@lenovo> References: <1253090551-7969-1-git-send-email-sheng@linux.intel.com> <1253090551-7969-9-git-send-email-sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1253090551-7969-9-git-send-email-sheng@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Sheng Yang Cc: Keir Fraser , Jeremy Fitzhardinge , Jun Nakajima , Eddie Dong , linux-kernel@vger.kernel.org, xen-devel List-Id: xen-devel@lists.xenproject.org [Sheng Yang - Wed, Sep 16, 2009 at 04:42:29PM +0800] | Xen hybrid guest don't use lapic, but smp_generic_interrupt() assume all it's | caller using lapic. | | Signed-off-by: Sheng Yang | --- | arch/x86/kernel/irq.c | 3 ++- | 1 files changed, 2 insertions(+), 1 deletions(-) | | diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c | index c3fe010..a887d25 100644 | --- a/arch/x86/kernel/irq.c | +++ b/arch/x86/kernel/irq.c | @@ -236,7 +236,8 @@ void smp_generic_interrupt(struct pt_regs *regs) | { | struct pt_regs *old_regs = set_irq_regs(regs); | | - ack_APIC_irq(); | + if (!disable_apic) | + ack_APIC_irq(); | | exit_idle(); Hi Sheng, is there was some problem with it? I'm asking you because if disable_apic=1 then any apic write/read operations become NOPs. So I don't see how it may hurt. But I could be missing something. -- Cyrill