From: Wolfgang Denk Date: Thu, 17 Sep 2009 09:56:58 +0200 Subject: [U-Boot] [PATCH 3/3] fsl_i2c: Impl. AN2819, rev 5 to calculate FDR/DFSR In-Reply-To: References: <1253100688-26184-1-git-send-email-Joakim.Tjernlund@transmode.se> <1253100688-26184-2-git-send-email-Joakim.Tjernlund@transmode.se> <1253100688-26184-3-git-send-email-Joakim.Tjernlund@transmode.se> <4AB1D082.6000102@denx.de> Message-ID: <20090917075658.0EE28832E864@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Joakim Tjernlund, In message you wrote: > > > > + u8 dfsr, fdr = 0x31; /* Default if no FDR found */ > > > + unsigned short A, B, Ga, Gb; > > > > Please do not use mixed-case variables, thanks. > > A and B are from the AN2819 spec and I used the same names to ease > identify with the spec. I rather keep them. Feel free to add a comment to explain the relation, but please use only lower-case identifiers. ... > Like so? > for(Ga = 0x4, A = 10; A <= 30; Ga++, A += 2) { Please also here: for (...) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It's certainly convenient the way the crime (or condition) of stupidity carries with it its own punishment, automatically admisistered without remorse, pity, or prejudice. :-) -- Tom Christiansen in <559seq$ag1$1@csnews.cs.colorado.edu>