From: Wolfgang Denk Date: Thu, 17 Sep 2009 15:05:59 +0200 Subject: [U-Boot] [PATCH] Correct ffs/fls regression for PowerPC etc In-Reply-To: <200909171456.33234.sr@denx.de> References: <20090917143940.5688e6b0@marrow.netinsight.se> <200909171456.33234.sr@denx.de> Message-ID: <20090917130559.7D3CF832E864@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stefan Roese, In message <200909171456.33234.sr@denx.de> you wrote: > > Thanks. I tested it on my faulting ppc4xx platform (sequoia). And the problem > is gone now, so thanks. Thanks for testing. > But I've spotted a problem with other platforms in this patch. See below... ... > > -#define ffs > > +#define PLATFORM_FFS > > Here you define "FFS" in upper case. ... which is acctually correct, as macro names _shall_ use upper case letters. ... > > -#define __set_bit > > +#define PLATFORM__set_bit This is not a legal macro name. > > -#define ffs > > +#define PLATFORM_ffs > > Here it's lower case. Yeah, the patch is not clean. > > -#ifndef ffs > > +#ifndef PLATFORM_ffs > > # define ffs generic_ffs > > #endif > > And here you check against lower case "_ffs". So the platforms with upper case > "_FFS" are still broken. Please fix and resubmit. Simon, this needs to be cleaned up. Please make sure to use upper case macro names only. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de You humans have that emotional need to express gratitude. "You're welcome," I believe, is the correct response. -- Spock, "Bread and Circuses", stardate 4041.2