From: Sheng Yang Subject: Re: [Xen-devel] [RFC][PATCH 07/10] xen/hybrid: Add PV timer support Date: Thu, 17 Sep 2009 13:54:51 +0800 Message-ID: <200909171354.52543.sheng@linux.intel.com> References: <1253090551-7969-1-git-send-email-sheng@linux.intel.com> <1253090551-7969-8-git-send-email-sheng@linux.intel.com> <4AB149BA.1000106@goop.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4AB149BA.1000106@goop.org> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: Jeremy Fitzhardinge Cc: Keir Fraser , Jeremy Fitzhardinge , xen-devel , Eddie Dong , linux-kernel@vger.kernel.org, Jun Nakajima List-Id: xen-devel@lists.xenproject.org On Thursday 17 September 2009 04:25:30 Jeremy Fitzhardinge wrote: > On 09/16/09 01:42, Sheng Yang wrote: > > If we have event channel, we can use VIRQ_TIMER to deliver timer > > interrupt, otherwise we would reuse IRQ0. > > What's the purpose of this? Why can we get a timer virq via event > channel as usual? I'm very dubious about having any platform > interrupts/apic interaction in this code. > > J Before this patch, we didn't enable event channel for hybrid guest. But I think it's reasonable to enable it. Separating the event channel patch into two, one for generic usage, and another one QEmu devices. I would try to do this. -- regards Yang, Sheng