From: Mike Snitzer Subject: Re: [PATCH 2/3] dm: Use blk_queue_copy_limits() Date: Fri, 18 Sep 2009 15:11:54 -0400 Message-ID: <20090918191154.GB30063@redhat.com> References: <4AB3B43D.9000802@ce.jp.nec.com> <4AB3B4B8.10300@ce.jp.nec.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4AB3B4B8.10300@ce.jp.nec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Jun'ichi Nomura Cc: "Martin K. Petersen" , linux-kernel@vger.kernel.org, device-mapper development , Jens Axboe , Alasdair G Kergon List-Id: dm-devel.ids On Fri, Sep 18 2009 at 12:26pm -0400, Jun'ichi Nomura wrote: > Use new blk_queue_copy_limits() so that invalid limits > (max_sectors == 0) are fixed up appropriately when copied to the queue. > > Signed-off-by: Kiyoshi Ueda > Signed-off-by: Jun'ichi Nomura > Reported-by: David Strand > Cc: Mike Snitzer > Cc: Alasdair G Kergon > Cc: Martin K. Petersen > Cc: Jens Axboe > --- > drivers/md/dm-table.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.31.work/drivers/md/dm-table.c > =================================================================== > --- linux-2.6.31.work.orig/drivers/md/dm-table.c > +++ linux-2.6.31.work/drivers/md/dm-table.c > @@ -1090,7 +1090,7 @@ void dm_table_set_restrictions(struct dm > /* > * Copy table's limits to the DM device's request_queue > */ > - q->limits = *limits; > + blk_queue_copy_limits(q, limits); > > if (limits->no_cluster) > queue_flag_clear_unlocked(QUEUE_FLAG_CLUSTER, q); How about just having 2 patches in the series and folding the above DM change into the first patch? Doesn't _really_ matter I guess... Anyway, these minor points aside: I like what you've done with this series. Acked-by: Mike Snitzer