From: akpm@linux-foundation.org Subject: [patch 21/21] libfs: return error code on failed attr set Date: Fri, 18 Sep 2009 13:06:03 -0700 Message-ID: <200909182006.n8IK639n019804@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Cc: linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, fengguang.wu@intel.com, hch@lst.de, npiggin@suse.de, tytso@mit.edu To: viro@zeniv.linux.org.uk Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:33696 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758561AbZIRUGe (ORCPT ); Fri, 18 Sep 2009 16:06:34 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Wu Fengguang Currently all simple_attr.set handlers return 0 on success and negative codes on error. Fix simple_attr_write() to return these error codes. Signed-off-by: Wu Fengguang Cc: Theodore Ts'o Cc: Al Viro Cc: Christoph Hellwig Cc: Nick Piggin Signed-off-by: Andrew Morton --- fs/libfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff -puN fs/libfs.c~libfs-return-error-code-on-failed-attr-set fs/libfs.c --- a/fs/libfs.c~libfs-return-error-code-on-failed-attr-set +++ a/fs/libfs.c @@ -739,10 +739,11 @@ ssize_t simple_attr_write(struct file *f if (copy_from_user(attr->set_buf, buf, size)) goto out; - ret = len; /* claim we got the whole input */ attr->set_buf[size] = '\0'; val = simple_strtol(attr->set_buf, NULL, 0); - attr->set(attr->data, val); + ret = attr->set(attr->data, val); + if (ret == 0) + ret = len; /* on success, claim we got the whole input */ out: mutex_unlock(&attr->mutex); return ret; _