From: Al Viro Subject: Re: [patch 20/21] vfs: no "(unreachable)" prefix for SYSVIPC maps in /proc/PID/maps Date: Mon, 21 Sep 2009 11:04:51 +0100 Message-ID: <20090921100451.GJ5858@ZenIV.linux.org.uk> References: <200909182006.n8IK62Db019767@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, mszeredi@suse.cz, Valdis.Kletnieks@vt.edu, agruen@suse.de, hch@lst.de, hugh.dickins@tiscali.co.uk, matthew@wil.cx To: akpm@linux-foundation.org Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:54083 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755865AbZIUKEs (ORCPT ); Mon, 21 Sep 2009 06:04:48 -0400 Content-Disposition: inline In-Reply-To: <200909182006.n8IK62Db019767@imap1.linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Sep 18, 2009 at 01:06:02PM -0700, akpm@linux-foundation.org wrote: > From: Miklos Szeredi > > The patch > > "vfs: fix d_path() for unreachable paths" > > generally changed d_path() to report unreachable paths with a special > prefix. This has an effect on /proc/${PID}/maps as well for memory maps > set up with shmem_file_setup() or hugetlb_file_setup(). These functions > set up unlinked files under a kernel-private vfsmount. Since this > vfsmount is unreachable from userspace, these maps will be reported with > the "(unreachable)" prefix. > > This is undesirable, because it changes the kernel ABI and might break > applications for no good reason. I'd rather see 17, 19 and 20 collapsed...